Fix TUnit assertion patterns and optimize JsonObject access#21
Closed
Copilot wants to merge 2 commits intofeature/v-13-upgradefrom
Closed
Fix TUnit assertion patterns and optimize JsonObject access#21Copilot wants to merge 2 commits intofeature/v-13-upgradefrom
Copilot wants to merge 2 commits intofeature/v-13-upgradefrom
Conversation
39 tasks
Co-authored-by: Blind-Striker <1965259+Blind-Striker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update LocalStack Aspire for .NET 10 support and TUnit migration
Fix TUnit assertion patterns and optimize JsonObject access
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed PR review feedback for the TUnit migration: replaced manual reference equality checks with TUnit assertions, optimized JsonObject access patterns, and corrected analyzer suppressions.
Changes
TUnit Assertion Pattern (
LocalStackProjectExtensionsTests.cs)ReferenceEquals+ exception throw withIsSameReferenceAsassertionJsonObject Access Optimization (
EagerLoadedServicesTests.cs)ContainsKey+ indexer double lookup to single indexer access with null checkvar value = obj["key"]; if (value is not null) { ... }Analyzer Suppression (
LocalStackAssertions.cs)expectedLocalStack.OptionsPackage Version (
Directory.Packages.props)Example
Before:
After:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.